On Thu, Aug 3, 2023 at 4:16 PM Jan Beulich via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> While the attribute is relevant for legacy- and VEX-encoded insns, it is
> of no relevance for EVEX-encoded ones.
>
> While there in <mask_codefor>avx512dq_broadcast<mode><mask_name>_1 add
> the missing "length_immediate".
Ok.
>
> gcc/
>
> * config/i386/sse.md
> (*<avx512>_eq<mode>3<mask_scalar_merge_name>_1): Drop
> "prefix_extra".
> (avx512dq_vextract<shuffletype>64x2_1_mask): Likewise.
> (*avx512dq_vextract<shuffletype>64x2_1): Likewise.
> (avx512f_vextract<shuffletype>32x4_1_mask): Likewise.
> (*avx512f_vextract<shuffletype>32x4_1): Likewise.
> (vec_extract_lo_<mode>_mask [AVX512 forms]): Likewise.
> (vec_extract_lo_<mode> [AVX512 forms]): Likewise.
> (vec_extract_hi_<mode>_mask [AVX512 forms]): Likewise.
> (vec_extract_hi_<mode> [AVX512 forms]): Likewise.
> (@vec_extract_lo_<mode> [AVX512 forms]): Likewise.
> (@vec_extract_hi_<mode> [AVX512 forms]): Likewise.
> (vec_extract_lo_v64qi): Likewise.
> (vec_extract_hi_v64qi): Likewise.
> (*vec_widen_umult_even_v16si<mask_name>): Likewise.
> (*vec_widen_smult_even_v16si<mask_name>): Likewise.
> (*avx512f_<code><mode>3<mask_name>): Likewise.
> (*vec_extractv4ti): Likewise.
> (avx512bw_<code>v32qiv32hi2<mask_name>): Likewise.
> (<mask_codefor>avx512dq_broadcast<mode><mask_name>_1): Likewise.
> Add "length_immediate".
>
> --- a/gcc/config/i386/sse.md
> +++ b/gcc/config/i386/sse.md
> @@ -4030,7 +4030,6 @@
> vpcmpeq<ssemodesuffix>\t{%2, %1,
> %0<mask_scalar_merge_operand3>|%0<mask_scalar_merge_operand3>, %1, %2}
> vptestnm<ssemodesuffix>\t{%1, %1,
> %0<mask_scalar_merge_operand3>|%0<mask_scalar_merge_operand3>, %1, %1}"
> [(set_attr "type" "ssecmp")
> - (set_attr "prefix_extra" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
>
> @@ -4128,7 +4127,6 @@
> vpcmpeq<ssemodesuffix>\t{%2, %1,
> %0<mask_scalar_merge_operand3>|%0<mask_scalar_merge_operand3>, %1, %2}
> vptestnm<ssemodesuffix>\t{%1, %1,
> %0<mask_scalar_merge_operand3>|%0<mask_scalar_merge_operand3>, %1, %1}"
> [(set_attr "type" "ssecmp")
> - (set_attr "prefix_extra" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
>
> @@ -11487,7 +11485,6 @@
> return "vextract<shuffletype>64x2\t{%2, %1, %0%{%5%}%N4|%0%{%5%}%N4, %1,
> %2}";
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -11506,7 +11503,6 @@
> return "vextract<shuffletype>64x2\t{%2, %1, %0|%0, %1, %2}";
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -11554,7 +11550,6 @@
> return "vextract<shuffletype>32x4\t{%2, %1, %0%{%7%}%N6|%0%{%7%}%N6, %1,
> %2}";
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -11577,7 +11572,6 @@
> return "vextract<shuffletype>32x4\t{%2, %1, %0|%0, %1, %2}";
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -11671,7 +11665,6 @@
> && (!MEM_P (operands[0]) || rtx_equal_p (operands[0], operands[2]))"
> "vextract<shuffletype>64x4\t{$0x0, %1, %0%{%3%}%N2|%0%{%3%}%N2, %1, 0x0}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "memory" "none,store")
> (set_attr "prefix" "evex")
> @@ -11691,7 +11684,6 @@
> return "#";
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "memory" "none,store,load")
> (set_attr "prefix" "evex")
> @@ -11710,7 +11702,6 @@
> && (!MEM_P (operands[0]) || rtx_equal_p (operands[0], operands[2]))"
> "vextract<shuffletype>64x4\t{$0x1, %1, %0%{%3%}%N2|%0%{%3%}%N2, %1, 0x1}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -11724,7 +11715,6 @@
> "TARGET_AVX512F"
> "vextract<shuffletype>64x4\t{$0x1, %1, %0|%0, %1, 0x1}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -11744,7 +11734,6 @@
> && (!MEM_P (operands[0]) || rtx_equal_p (operands[0], operands[2]))"
> "vextract<shuffletype>32x8\t{$0x1, %1, %0%{%3%}%N2|%0%{%3%}%N2, %1, 0x1}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -11762,7 +11751,6 @@
> vextract<shuffletype>32x8\t{$0x1, %1, %0|%0, %1, 0x1}
> vextracti64x4\t{$0x1, %1, %0|%0, %1, 0x1}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "isa" "avx512dq,noavx512dq")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> @@ -11850,7 +11838,6 @@
> && (!MEM_P (operands[0]) || rtx_equal_p (operands[0], operands[2]))"
> "vextract<shuffletype>32x8\t{$0x0, %1, %0%{%3%}%N2|%0%{%3%}%N2, %1, 0x0}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "memory" "none,store")
> (set_attr "prefix" "evex")
> @@ -11880,7 +11867,6 @@
> return "#";
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "memory" "none,load,store")
> (set_attr "prefix" "evex")
> @@ -11923,7 +11909,6 @@
> && (!MEM_P (operands[0]) || rtx_equal_p (operands[0], operands[2]))"
> "vextract<shuffletype>64x2\t{$0x0, %1, %0%{%3%}%N2|%0%{%3%}%N2, %1, 0x0}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "memory" "none,store")
> (set_attr "prefix" "evex")
> @@ -11961,7 +11946,6 @@
> && (!MEM_P (operands[0]) || rtx_equal_p (operands[0], operands[2]))"
> "vextract<shuffletype>64x2\t{$0x1, %1, %0%{%3%}%N2|%0%{%3%}%N2, %1, 0x1}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "vex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -12013,7 +11997,6 @@
> && (!MEM_P (operands[0]) || rtx_equal_p (operands[0], operands[2]))"
> "vextract<shuffletype>32x4\t{$0x0, %1, %0%{%3%}%N2|%0%{%3%}%N2, %1, 0x0}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -12102,7 +12085,6 @@
> operands[1] = gen_lowpart (<ssehalfvecmode>mode, operands[1]);
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "memory" "none,load,store")
> (set_attr "prefix" "evex")
> @@ -12123,7 +12105,6 @@
> "TARGET_AVX512F"
> "vextracti64x4\t{$0x1, %1, %0|%0, %1, 0x1}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "XI")])
> @@ -12204,7 +12185,6 @@
> operands[1] = gen_lowpart (V32QImode, operands[1]);
> }
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "memory" "none,load,store")
> (set_attr "prefix" "evex")
> @@ -12233,7 +12213,6 @@
> "TARGET_AVX512F"
> "vextracti64x4\t{$0x1, %1, %0|%0, %1, 0x1}"
> [(set_attr "type" "sselog1")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "XI")])
> @@ -15446,7 +15425,6 @@
> "TARGET_AVX512F && !(MEM_P (operands[1]) && MEM_P (operands[2]))"
> "vpmuludq\t{%2, %1, %0<mask_operand3>|%0<mask_operand3>, %1, %2}"
> [(set_attr "type" "sseimul")
> - (set_attr "prefix_extra" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "XI")])
>
> @@ -15562,7 +15540,6 @@
> "TARGET_AVX512F && !(MEM_P (operands[1]) && MEM_P (operands[2]))"
> "vpmuldq\t{%2, %1, %0<mask_operand3>|%0<mask_operand3>, %1, %2}"
> [(set_attr "type" "sseimul")
> - (set_attr "prefix_extra" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "XI")])
>
> @@ -16585,7 +16562,6 @@
> "TARGET_AVX512F && !(MEM_P (operands[1]) && MEM_P (operands[2]))"
> "vp<maxmin_int><ssemodesuffix>\t{%2, %1,
> %0<mask_operand3>|%0<mask_operand3>, %1, %2}"
> [(set_attr "type" "sseiadd")
> - (set_attr "prefix_extra" "1")
> (set_attr "prefix" "maybe_evex")
> (set_attr "mode" "<sseinsnmode>")])
>
> @@ -20322,7 +20298,6 @@
> "TARGET_AVX512F"
> "vextracti32x4\t{%2, %1, %0|%0, %1, %2}"
> [(set_attr "type" "sselog")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "XI")])
> @@ -21893,7 +21868,6 @@
> }
> [(set_attr "type" "sseishft")
> (set_attr "atom_unit" "sishuf")
> - (set_attr "prefix_extra" "1")
> (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
> @@ -22666,7 +22640,6 @@
> "TARGET_AVX512BW"
> "vpmov<extsuffix>bw\t{%1, %0<mask_operand2>|%0<mask_operand2>, %1}"
> [(set_attr "type" "ssemov")
> - (set_attr "prefix_extra" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "XI")])
>
> @@ -26796,7 +26769,7 @@
> vshuf<shuffletype>32x4\t{$0x44, %g1, %g1,
> %0<mask_operand2>|%0<mask_operand2>, %g1, %g1, 0x44}
> vbroadcast<shuffletype>32x8\t{%1, %0<mask_operand2>|%0<mask_operand2>,
> %1}"
> [(set_attr "type" "ssemov")
> - (set_attr "prefix_extra" "1")
> + (set_attr "length_immediate" "1,*")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
>
> @@ -26813,7 +26786,7 @@
> vshuf<shuffletype>64x2\t{$0x0, %<xtg_mode>1, %<xtg_mode>1,
> %0<mask_operand2>|%0<mask_operand2>, %<xtg_mode>1, %<xtg_mode>1, 0x0}
> vbroadcast<shuffletype>64x2\t{%1, %0<mask_operand2>|%0<mask_operand2>,
> %1}"
> [(set_attr "type" "ssemov")
> - (set_attr "prefix_extra" "1")
> + (set_attr "length_immediate" "1")
> (set_attr "prefix" "evex")
> (set_attr "mode" "<sseinsnmode>")])
>
>
--
BR,
Hongtao
