No. prepare_ternary can not be seperate patch.
It's a bug fix patch which is discovered in autovectorization.

Thanks for comments. I will commit it when middle-end is approved by Richi.

>> As to the lmul = 8 ICE, is the problem that the register allocator
>> would actually need 5 "registers" when doing the merge by itself
>> and we only have 4?
Yes.



juzhe.zh...@rivai.ai
 
From: Robin Dapp
Date: 2023-08-03 19:03
To: Juzhe-Zhong; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; jeffreyalaw
Subject: Re: [PATCH V2] RISC-V: Support CALL conditional autovec patterns
Hi Juzhe,
 
I would find it a bit clearer if the prepare_ternay part were a
separate patch.  As it's mostly mechanical replacements I don't
mind too much, though so it's LGTM from my side without that.
 
As to the lmul = 8 ICE, is the problem that the register allocator
would actually need 5 "registers" when doing the merge by itself
and we only have 4?
 
Regards
Robin
 

Reply via email to