On Mon, 31 Jul 2023, Lewis Hyatt via Gcc-patches wrote: > I added some additional testcases from the PR for x86. The other targets > that support `#pragma GCC target' (aarch64, arm, nios2, powerpc, s390) > already had tests verifying that the pragma sets macros as expected; here I > have added -save-temps to some of them, to test that it now works in > preprocess-only mode as well.
It would seem better to have copies of the tests with and without -save-temps, to test in both modes, rather than changing what's tested by an existing test here. Or a test variant that #includes the original test but uses different options, if the original test isn't doing anything that would fail to work with that approach. -- Joseph S. Myers jos...@codesourcery.com
