On Mon, 3 Jul 2023, Kito Cheng via Gcc-patches wrote: > Lgtm > > > juzhe.zh...@rivai.ai <juzhe.zh...@rivai.ai>於 2023年7月3日 週一，19:11寫道： > > > LGTM > > > > > > > > juzhe.zh...@rivai.ai > > > > From: pan2.li > > Date: 2023-07-03 18:57 > > To: gcc-patches > > CC: juzhe.zhong; jeffreyalaw; pan2.li; yanzhang.wang; kito.cheng > > Subject: [PATCH v1] RISC-V: Fix one typo for emit_mode_set. > > From: Pan Li <pan2...@intel.com> > > > > This patch would like to fix one typo for scaler[should be scalar] in > > emit_mode_set, as well as minor change for mov emit.
These should be two separate changes though: one obviously correct for the typo fix and the other one for the semantic change. We have it explicitly documented even: "Don't mix together changes made for different reasons. Send them individually. Ideally, each change you send should be impossible to subdivide into parts that we might want to consider separately, because each of its parts gets its motivation from the other parts. In particular, changes to code formatting to conform to coding standards are best not mixed with substantive changes, because that makes it difficult to see what the real changes are." cf. <https://gcc.gnu.org/contribute.html#patches>. There are various reasons for this requirement beyond these stated above, e.g. someone may want to backport the semantic change only downstream and not the trivial fix, or we may want to revert one commit later on for some reason and not to have to disentangle it first. Maciej
