Olivier Hainque <hain...@adacore.com> writes: > Hello Richard, > > Re $subject, at http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01515.html > > You suggested: >>> Would be nice to use a single function that knows about the extra >>> contraints here. Maybe something like the attached? > > << 2012-04-24 ... > > * rtl.h (set_for_reg_notes): Declare. > * emit-rtl.c (set_for_reg_notes): New function. > (set_unique_reg_note): Use it. > * optabs.c (add_equal_note): Likewise. >>> > > I had answered: >> Looks cleaner indeed. Do you want me to test ? > > I gave it a try. Your patch bootstraps and regtests fine on mainline for > x86-linux.
Sorry, was going to test this earlier, but got distracted by lower-subreg stuff. I need to fix the subreg handling so that we check whether the inner part of a SUBREG is a REG (done in my copy at home). I also wanted to make sure there were no asm differences due to notes being wrongly dropped. Hope to do that this weekend. Richard
