On Thu, May 3, 2012 at 12:59 AM, Xinyu Qi <x...@marvell.com> wrote: >> From: Matt Turner [mailto:matts...@gmail.com] >> To: Xinyu Qi >> Cc: Ramana Radhakrishnan; GCC Patches >> Subject: Re: [PING] iwMMXt patches >> >> On Tue, Apr 17, 2012 at 4:17 PM, Matt Turner <matts...@gmail.com> wrote: >> > Are these patches ready to go in? It looks like they were ack'd. >> > >> > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01815.html >> > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01817.html >> > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01816.html >> > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01818.html >> > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01819.html >> > >> > We (OLPC) will need these patches for reasonable iwMMXt performance >> > and the ability to use VFP and iwMMXt together. >> > >> > Thanks, >> > Matt >> >> Xinyu, >> >> With these patches I don't see a new -mcpu flag. Isn't a tune/cpu flag >> the normal way to activate this code? >> >> Other .md files have statements like (eq_attr "tune" "cortexa8"), but >> I don't see how to turn on the marvell-f-iwmmxt attribute, ie (eq_attr >> "marvell_f_iwmmxt" "yes"). >> >> Please let me know. >> >> Thanks, >> Matt > > Hi Matt, > > I updated the patches several months ago by following the review opinions > form Richard Earnshaw [richard.earns...@arm.com] > (unfortunately, no further feedback) > The newest patches are > http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01787.html > http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01788.html > http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01789.html > http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01786.html > http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01599.html > The main discussion is in > http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01786.html > > No new -mcpu flag is introduced in the patches. You can simply turn on > marvell-f-iwmmxt by -mcpu=iwmmxt2(or -march=iwmmxt2). > (Of course it is odd to treat the "iwmmxt2" as a name of cpu) > > > Thanks, > Xinyu
Thanks for the email, Xinyu! We (OLPC) will test the patches and then I'll resubmit them to gcc-patches@ and try to get them included. They're definitely needed for us, since they fix PR35294 (iwmmxt shift and logical intrinsics are broken). By the way, are there patches for add general instruction scheduling support for Marvell CPUs like the Armada 610? Thanks again, Matt
