On Fri, 2023-07-07 at 10:15 +0800, Kewen.Lin wrote:
<snip> > > > diff --git a/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-func- > > 1op-compile.c b/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-func- > > 1op-compile.c > > new file mode 100644 > > index 00000000000..6b7d73ed66c > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-func-1op- > > compile.c > > Nit: Maybe remove "-compile" from the name as when there is "-run" > variant people > are easy to realize this is for compilation, the name without "- > compile" seems > more neat. With this name change, you have to update the comment > referring it in > its related header file accordingly. ("sed -i 's/-compile//g' vsx- > vector-6-func-*.h" > recommended, similar patterns could be used for the two other > comments below.) Changed the compile only file names as requested. Updated the file names in the .h files. Updated the Change Log file names. > > > @@ -0,0 +1,22 @@ > > +/* { dg-do compile { target lp64 } } */ > > +/* { dg-require-effective-target powerpc_vsx_ok } */ > > +/* { dg-options "-O2 -save-temps -mvsx" } */ > > Nit: We don't need "-save-temps" any more for all the test cases in > this patch. > Yup, -save-temps is on automatically for compile only and we are not checking instructions in the run file. Removed all of the -save-temp directives. > > + > > +/* This file just generates calls to the various builtins and > > verifies the > > + expected number of instructions for each builtin were > > generated. */ > > + > > +#include "vsx-vector-6-func-1op.h" > > + > > +/* { dg-final { scan-assembler-times {\mxvabssp\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrspip\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrspim\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrspi\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrspic\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrspiz\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvabsdp\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrdpip\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrdpim\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrdpi\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrdpic\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvrdpiz\M} 1 } } */ > > +/* { dg-final { scan-assembler-times {\mxvsqrtdp\M} 1 } } */ > > diff --git a/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-func- > > 1op-run.c b/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-func-1op- > > run.c > > new file mode 100644 > > index 00000000000..150e372e428 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-func-1op-run.c > > @@ -0,0 +1,98 @@ > > +/* { dg-do run { target lp64 } } */ > > +/* { dg-require-effective-target powerpc_vsx_ok } */ > > We need vsx_hw for those *-run.c cases instead, as powerpc_vsx_ok > doesn't guarantee the test env can support vsx instructions, it just > ensures it can be compiled. > > /* { dg-require-effective-target vsx_hw } */ > > All "*-run.c" cases need changes. Updated the run cases to use vsx_hw, removed powerpc_vsx_ok. Carl