Hi Joseph,

> 
> On Thu, 3 May 2012, Terry Guo wrote:
> 
> > Thanks for your reminding.
> > The attached patch added the missing documentation. Please help to
> review.
> 
> Please send the complete new patch, including documentation, for review
> (unless the rest has been reviewed).
> 
> > +@item MULTILIB_REQUIRED
> > +Sometimes when there are only a few combinations are required, it
> would
> > +be a big effort to come up with @code{MULTILIB_EXCEPTIONS} list to
> 
> "a @code{MULTILIB_EXCEPTIONS} list"
> 
> > +cover all undesired ones.  In such case, just listing all the
> required
> 
> "such a case"
> 
> > +combinations in @code{MULTILIB_REQUIRED} would be more
> straightforward.
> > +
> > +The @code{MULTILIB_REQUIRED} can work with
> @code{MULTILIB_EXCEPTIONS}.
> 
> "@code{MULTILIB_REQUIRED} can be used together with
> @code{MULTILIB_EXCEPTIONS}."
> 
> > +The option combinations generated from @code{MULTILIB_OPTIONS} will
> be
> > +filtered by @code{MULTILIB_EXCEPTIONS} and then by
> @code{MULTILIB_REQUIRED}.
> 
> I think you need more details of the exact syntax of entries in
> MULTILIB_REQUIRED.  Are they sets of options from MULTILIB_OPTIONS,
> separated by '/', with no wildcards or other substitutions, or is the
> syntax something else?
> 

A updated patch is attached and your comments are included. Please review
again. Thanks.

BR,
Terry

2012-05-03  Terry Guo  <terry....@arm.com>

        * Makefile.in (s-mlib): Add new argument MULTILIB_REQUIRED.
        * genmultilib (MULTILIB_REQUIRED): New.
        * doc/fragments.texi: Document the MULTILIB_REQUIRED.

Attachment: Add-a-new-term-MULTILIB_REQUIRED-v3.patch
Description: Binary data

Reply via email to