On Wed, Jul 5, 2023 at 6:25 PM Thomas Schwinge <tho...@codesourcery.com> wrote:
>
> Hi!
>
> My original motivation for the following exercise what that, for example,
> for: 'const unsigned char * GTY((atomic)) mode_table', we currently run
> into 'const' mismatches, 'error: invalid conversion':
>
>     [...]
>     gtype-desc.cc: In function 'void gt_pch_nx_lto_file_decl_data(void*)':
>     gtype-desc.cc:6531:34: error: invalid conversion from 'const void*' to 
> 'void*' [-fpermissive]
>              gt_pch_note_object ((*x).mode_table, x, 
> gt_pch_p_18lto_file_decl_data);
>                                       ^
>     In file included from [...]/source-gcc/gcc/hash-table.h:247:0,
>                      from [...]/source-gcc/gcc/coretypes.h:486,
>                      from gtype-desc.cc:23:
>     [...]/source-gcc/gcc/ggc.h:47:12: note:   initializing argument 1 of 'int 
> gt_pch_note_object(void*, void*, gt_note_pointers, size_t)'
>      extern int gt_pch_note_object (void *, void *, gt_note_pointers,
>                 ^
>     make[2]: *** [Makefile:1180: gtype-desc.o] Error 1
>     [...]
>
> ..., as I had reported as "'GTY' issues: (1) 'const' build error" in
> <https://inbox.sourceware.org/87o7kxuq9s....@euler.schwinge.homeip.net>
> 'Adjust LTO mode tables for "Machine_Mode: Extend machine_mode from 8 to 16 
> bits"'.
>
> That said:
>
> On 2011-05-16T02:13:56+0200, "Nicola Pero" <nicola.p...@meta-innovation.com> 
> wrote:
> > This patch adds a new GTY option, "atomic", which is similar to the 
> > identical option you have with Boehm GC
> > and which can be used with pointers to inform the GC/PCH machinery that 
> > they point to an area of memory that
> > contains no pointers (and hence needs no scanning).
> >
> > [...]
>
> On top of that, OK to push the attached
> "GGC, GTY: No pointer walking for 'atomic' in PCH 'gt_pch_note_object'"?
> Appreciate review from a GGC, GTY-savvy person.

OK.  Thanks for the detailed explanations, that helps even a not
GGC/GTY savy person to
review this ;)

Thanks,
Richard.

> This depends on
> <https://inbox.sourceware.org/87edlmtjwh....@euler.schwinge.homeip.net>
> "GGC, GTY: Tighten up a few things re 'reorder' option and strings".
>
>
> Grüße
>  Thomas
>
>
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 
> München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas 
> Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht 
> München, HRB 106955

Reply via email to