> There has to be some kind of mismatch between the patch or testcase > or what we're looking at to judge success.
Yeah I think the initially posted example was misleading because it contained an already working example. > While I really don't see the need to have the bridge pattern, I'm > still willing to believe that I've missed something, which is why I > wanted to dive into it myself. For example, we have heuristics to > avoid trying too many 4->n combine patterns and we might be tripping > over that or who knows what. > > So my suggestion is that if both of you are getting the desired code, > then Robin handle the review side of the two patches that introduce > the helper patterns. I went over both patches again and given the context they seem reasonable to me. I'd propose go with both of them for now and - in the meanwhile - I'm going to brush up on my combine knowledge some time in the next weeks and get back to this then, hopefully with a better explanation than my last one. Regards Robin
