On 6/21/23 11:20 AM, Paul E Murphy via Gcc-patches wrote: > > > On 6/19/23 3:39 AM, Thomas Schwinge wrote: >> Hi Paul! >> >> On 2023-06-16T11:00:02-0500, "Paul E. Murphy via Gcc-patches" >> <gcc-patches@gcc.gnu.org> wrote: >>> This was noticed when fixing the gccgo usage of the macro, the >>> rust usage is very similar. >>> >>> TARGET_AIX is defined as a non-zero value on linux/powerpc64le >>> which may cause unexpected behavior. TARGET_AIX_OS should be >>> used to toggle AIX specific behavior. >>> >>> gcc/rust/ChangeLog: >>> >>> * rust-object-export.cc [TARGET_AIX]: Rename and update >>> usage to TARGET_AIX_OS. >> >> I don't have rights to formally approve this GCC/Rust change, but I'll >> note that it follows "as obvious" (see >> <https://gcc.gnu.org/gitwrite.html#policies>, "Obvious fixes") to the >> corresponding GCC/Go change, which has been approved: >> <https://inbox.sourceware.org/cakoqz8wdwc7g5_jbnk1jvgchhiurceeamzb5bqrx_vzjejp...@mail.gmail.com>, >> and which is where this GCC/Rust code has been copied from, so I suggest >> you push both patches at once. >> >> >> Grüße >> Thomas > > Hi Thomas, > > Thank you for reviewing. I do not have commit access, so I cannot push this > myself. If this is OK, could one of the rust maintainers push this patch? > > Thanks, > Paul
I pushed this to trunk for Paul. Peter
