Re: [PATCH] RISC-V: Add tuple vector mode psABI checking and simplify code

[Lehua Ding]

> -/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
> +/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" 
} */

By the way, shouldn't these cases have the `-mabi=lp64d` option added,
otherwise I get the following failure message when I run tests on RV32 GCC.


  FAIL: gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-1.c -std=c99 -O3 
-ftree-vectorize --param riscv-autovec-preference=fixed-vlmax (test for excess 
errors)
  Excess errors.
  cc1: error: ABI requires '-march=rv32'



Best,
Lehua


------------------ Original ------------------
From: &nbsp;"Robin&nbsp;Dapp"<rdapp....@gmail.com&gt;;
Date: &nbsp;Tue, Jun 20, 2023 08:10 PM
To: &nbsp;"pan2.li"<pan2...@intel.com&gt;; "Jeff 
Law"<jeffreya...@gmail.com&gt;; "钟居哲"<juzhe.zh...@rivai.ai&gt;; 
"丁乐华"<lehua.d...@rivai.ai&gt;; "gcc-patches"<gcc-patches@gcc.gnu.org&gt;; 
Cc: &nbsp;"Robin Dapp"<rdapp....@gmail.com&gt;; 
"yanzhang.wang"<yanzhang.w...@intel.com&gt;; 
"kito.cheng"<kito.ch...@gmail.com&gt;; "palmer"<pal...@rivosinc.com&gt;; 
Subject: &nbsp;Re: [PATCH] RISC-V: Add tuple vector mode psABI checking and 
simplify code

&nbsp;

&gt; Committed, thanks Jeff.

The vec_set/vec_extract tests FAIL since this commit.&nbsp; I'm going to
commit the attached as obvious.

Lehua, would they not show up in your test runs?&nbsp; You fixed several
other tests but these somehow not?

Regards
&nbsp;Robin

Subject: [PATCH] RISC-V: testsuite: Add -Wno-psabi to vec_set/vec_extract
&nbsp;testcases.

This fixes some fallout from the recent psabi changes.

gcc/testsuite/ChangeLog:

        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-1.c: Add
        -Wno-psabi.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-2.c: Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-3.c: Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-4.c: Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c:
        Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-1.c: Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-2.c: Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-3.c: Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-4.c: Dito.
        * gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-run.c: Dito.
---
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-1.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-2.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-3.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-4.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-1.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-2.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-3.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-4.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;.../gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-run.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 | 2 +-
&nbsp;10 files changed, 10 insertions(+), 10 deletions(-)

diff --git 
a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-1.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-1.c
index 1a6e6dd83ee..34efd5f700a 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-1.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-1.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git 
a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-2.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-2.c
index 884c38e0bd8..5f3168a320a 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-2.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-2.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git 
a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-3.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-3.c
index 844ad392df0..7210327a4ff 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-3.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-3.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git 
a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-4.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-4.c
index 04c234e7d2d..c5cb56a88c7 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-4.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-4.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git 
a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c
index dd22dae5eb9..43110c0bb8d 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_extract-run.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do run { target { riscv_vector } } } */
-/* { dg-additional-options "-std=c99 -Wno-pedantic" } */
+/* { dg-additional-options "-std=c99 -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <assert.h&gt;
&nbsp;
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-1.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-1.c
index 4fb4e822b93..28f11150f8f 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-1.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-1.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-2.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-2.c
index 379e92f30bb..1f2aaeaf2df 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-2.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-2.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-3.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-3.c
index b1e78150b30..dfd1ff2aa86 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-3.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-3.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-4.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-4.c
index 0b7f53d1cf3..eb63435d2f0 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-4.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-4.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do compile } */
-/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic" } */
+/* { dg-additional-options "-march=rv64gcv_zvfh -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <stdint-gcc.h&gt;
&nbsp;
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-run.c 
b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-run.c
index bf04a3d029e..6a08f26e099 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-run.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/vls-vlmax/vec_set-run.c
@@ -1,5 +1,5 @@
&nbsp;/* { dg-do run { target { riscv_vector } } } */
-/* { dg-additional-options "-std=c99 -Wno-pedantic" } */
+/* { dg-additional-options "-std=c99 -Wno-pedantic -Wno-psabi" } */
&nbsp;
&nbsp;#include <assert.h&gt;
&nbsp;
-- 
2.40.1