HP, It makes sense. I will update the patch. Thanks Gui Haochen
在 2023/6/20 8:07, Hans-Peter Nilsson 写道: > On Tue, 30 May 2023, HAO CHEN GUI via Gcc-patches wrote: > >> +++ b/gcc/config/rs6000/rs6000.md >> @@ -7891,6 +7891,36 @@ (define_insn "*mov<mode>_internal2" >> (set_attr "dot" "yes") >> (set_attr "length" "4,4,8")]) >> >> +(define_peephole2 >> + [(set (match_operand:CC 2 "cc_reg_operand" "") >> + (compare:CC (match_operand:P 1 "int_reg_operand" "") >> + (const_int 0))) >> + (set (match_operand:P 0 "int_reg_operand" "") > > A random comment from the sideline: I'd suggest to remove the > (empty) constraints string from your peephole2's. > > It can be a matter of port-specific-taste but it seems removing > them would be consistent with the other peephole2's in > rs6000.md. > > (In this matter, I believe the examples in md.texi are bad.) > > brgds, H-P
