>> as the tests are mostly directly from aarch64's testsuite I would >> advise comments on where they were taken from as well as a TODO that >> they should become common tests for a specific target selector >> (vect_scalable_supported or something).
Ok. >> (How about some assembly checks for the non-run tests? No, I tried. I can't add assembly check in the tests since we are SLP using different LMUL. Different LMUL will end up with different SLP style and their instructions are quite different. Unless we can have assembly check with predicate recognizing LMUL=M1/M2/M4/M8 juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-06-13 18:08 To: juzhe.zhong; gcc-patches CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw Subject: Re: [PATCH] RISC-V: Add more SLP tests Hi Juzhe, as the tests are mostly directly from aarch64's testsuite I would advise comments on where they were taken from as well as a TODO that they should become common tests for a specific target selector (vect_scalable_supported or something). How about some assembly checks for the non-run tests? Regards Robin
