On Fri, 2023-06-09 at 20:28 +0200, Tim Lange wrote:
[...snip...]
Thanks for the patch.
> diff --git a/gcc/analyzer/constraint-manager.cc
> b/gcc/analyzer/constraint-manager.cc
> index 2c9c435527e..24cd8960098 100644
> --- a/gcc/analyzer/constraint-manager.cc
> +++ b/gcc/analyzer/constraint-manager.cc
> @@ -2218,6 +2218,137 @@ constraint_manager::get_equiv_class_by_svalue (const
> svalue *sval,
> return false;
> }
>
> +/* Tries to find a svalue inside another svalue. */
> +
> +class sval_finder : public visitor
> +{
> +public:
> + sval_finder (const svalue *query) : m_query (query)
> + {
> + }
It looks like this ctor is missing an initialization of the new field
"m_found" to false.
[...snip...]
> +private:
> + const svalue *m_query;
> + bool m_found;
> +};
> +
[...snip...]
Other than that, looks good to me.
Dave
