On 06/06/2023 16:33, Tobias Burnus wrote:
Andrew: Does the GCN change look okay to you?

This patch permits to use GCN devices with 'omp requires unified_address' which in principle works already, except that the requirement handling did disable it.

(It also updates libgomp.texi for this change and likewise for an older likewise nvptx change.)

I will later add a testcase → https://gcc.gnu.org/PR109837>> However, the patch was tested with the respective sollve_vv testcase with an additional fix applied on top → https://github.com/SOLLVE/sollve_vv/pull/737>> (I do note that with the USM patches for OG12/OG13, unified_address is accepted, cf. OG13 https://gcc.gnu.org/g:3ddf3565faee70e8c910d90ab0c80e71813a0ba1 ,
but USM itself goes much beyond what we need here.)

OK, I think this is fine. I was going to do this with the patch series soon anyway.

Andrew

Reply via email to