Committed with that change, thanks Jeff. Pan
-----Original Message----- From: Gcc-patches <gcc-patches-bounces+pan2.li=intel....@gcc.gnu.org> On Behalf Of ??? Sent: Wednesday, May 31, 2023 9:24 PM To: Jeff Law <jeffreya...@gmail.com>; rdapp.gcc <rdapp....@gmail.com>; gcc-patches <gcc-patches@gcc.gnu.org> Cc: kito.cheng <kito.ch...@gmail.com>; kito.cheng <kito.ch...@sifive.com>; palmer <pal...@dabbelt.com>; palmer <pal...@rivosinc.com> Subject: Re: Re: [PATCH] RISC-V: Add vwadd<u>/vwsub<u>/vwmul<u>/vwmulsu.vv lowering optimizaiton for RVV auto-vectorization I have sent V2 withing adding commen: https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620243.html Could you take a look at it? juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-05-31 20:58 To: Robin Dapp; juzhe.zhong; gcc-patches CC: kito.cheng; kito.cheng; palmer; palmer Subject: Re: [PATCH] RISC-V: Add vwadd<u>/vwsub<u>/vwmul<u>/vwmulsu.vv lowering optimizaiton for RVV auto-vectorization On 5/31/23 05:55, Robin Dapp wrote: > Hi Juzhe, > >> The approach is quite simple and obvious, changing extension pattern >> into define_insn_and_split will make combine PASS combine into widen >> operations naturally. > > looks good to me. Tiny nit: I would add a comment above the patterns > to clarify why insn_and_split instead of expand. Something like "to help > combine match...", no need for a V2 though. OK with that change. jeff
