LGTM, just a couple of comment tweaks: Prathamesh Kulkarni <prathamesh.kulka...@linaro.org> writes: > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > index d6fc94015fa..db7ca4c28c3 100644 > --- a/gcc/config/aarch64/aarch64.cc > +++ b/gcc/config/aarch64/aarch64.cc > @@ -22332,6 +22332,46 @@ aarch64_unzip_vector_init (machine_mode mode, rtx > vals, bool even_p) > return gen_rtx_PARALLEL (new_mode, vec); > } > > +/* Return true if INSN is a scalar move. */
s/INSN/SET/ > + > +static bool > +scalar_move_insn_p (rtx set) > +{ > + rtx src = SET_SRC (set); > + rtx dest = SET_DEST (set); > + return (is_a<scalar_mode> (GET_MODE (dest)) > + && aarch64_mov_operand (src, GET_MODE (dest))); > +} > + > +/* Similar to seq_cost, but ignore cost for scalar moves. This function > + is called from aarch64_expand_vector_init. */ Probably best to drop the second sentence. OK with those changes, thanks (no need to retest). Richard