On Mon, Apr 23, 2012 at 08:45:18AM -0600, Tom Tromey wrote: > Tom> Here is a new patch for gcc. > Tom> I still haven't updated the src side, but there's little to do there > Tom> that isn't already done in this patch. > > Tom> Ok? > > Tom> Ping. > > Tom> Ping. > > This is the third ping. > > Please review the patch. > > There are two choices: > > 1. Approve the original patch, adding a file to libiberty. > Given how much code in libiberty is already unrelated to portability, > I would say this is the simplest route. > From a quick glance -- concat.c, the demangler, crc32.c, > dyn-string.c, fdmatch.c, fibheap.c, hashtab.c, hex.c, md5.c, > objalloc.c, obstack.c, sha1.c, simple-object*.
Yeah, that would be my preference. libiberty is already a kitchen sink, has been handled that way for many years, and creating a new kitchen sink library is both overkill and will not make it a kitchen sink if only this dwarf strings stuff is added to that and all the other kitchen sink stuff stays in libiberty. Jakub