on 2023/5/17 14:32, Richard Biener wrote:
> On Wed, May 17, 2023 at 8:06 AM Kewen.Lin <li...@linux.ibm.com> wrote:
>>
>> Hi,
>>
>> When working on a cost tweaking patch, I found that a newly
>> added test case has different dumpings with stage-1 and
>> bootstrapped gcc. By looking into it, the apparent reason
>> is vect_analyze_loop_2 doesn't get slp_done_for_suggested_uf
>> set expectedly, the following retrying will use the garbage
>> slp_done_for_suggested_uf instead. In fact, the setting of
>> slp_done_for_suggested_uf only happens when the previous
>> analysis succeeds, for the mentioned test case, its previous
>> analysis does fail, it's unexpected to use the value of
>> slp_done_for_suggested_uf any more.
>>
>> In function vect_analyze_loop_1, we only return success when
>> res is true, which is the result of 1st analysis. It means
>> we never try to vectorize with unroll_vinfo if the previous
>> analysis fails. So this patch shouldn't break anything, and
>> just stop some useless analysis early.
>>
>> Bootstrapped and regtested on x86_64-redhat-linux,
>> aarch64-linux-gnu and powerpc64{,le}-linux-gnu.
>>
>> Is it ok for trunk?
>
> OK for trunk and affected branches.
Pushed as r14-926 and backported in r13-7364 & r12-9633. Thanks!
BR,
Kewen
