On Thu, 18 May 2023 at 13:59, Jakub Jelinek wrote:

> On Thu, May 18, 2023 at 01:56:46PM +0100, Jonathan Wakely via Gcc-patches
> wrote:
> > --- a/gcc/testsuite/gcc.test-framework/gen_directive_tests
> > +++ b/gcc/testsuite/gcc.test-framework/gen_directive_tests
> > @@ -322,8 +322,8 @@ two() {
> >      echo "${GOOD_PROG}" >> $FILE1
> >      echo "${GOOD_PROG}" > $FILE2
> >
> > -    if [ "${FAIL_VERSION}" == "yes" ]; then
> > -     if [ "${EXP}" == "${EXP_PASS}" ]; then
> > +    if  "yes" ]; then
>
> This line looks suspicious...
>

Yikes! I think instead of clicking on the first '=' character I must have
selected the whole of `"${FAIL_VERSION}" =` and then deleted it all.

v2 patch at https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618919.html


> > +     if [ "${EXP}" = "${EXP_PASS}" ]; then
> >           NAME=${KIND1}-${KIND2}-${EXP_FAIL}
> >       else
> >           NAME=${KIND1}-${KIND2}-${EXP_XFAIL}
> > @@ -364,8 +364,8 @@ three() {
> >      echo "${GOOD_PROG}" >> $FILE1
> >      echo "${GOOD_PROG}" > $FILE2
> >
> > -    if [ "${FAIL_VERSION}" == "${yes}" ]; then
> > -     if [ "${EXP}" == "${EXP_PASS}" ]; then
> > +    if [ "${FAIL_VERSION}" = "${yes}" ]; then
> > +     if [ "${EXP}" = "${EXP_PASS}" ]; then
> >           NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_FAIL}
> >       else
> >           NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_XFAIL}
> > --
> > 2.40.1
>
>         Jakub
>
>

Reply via email to