Hi Julian! On 2023-04-27T11:36:47-0700, Julian Brown <jul...@codesourcery.com> wrote: > This patch fixes several cases where multiple attach or detach mapping > nodes were being created for stand-alone attach or detach clauses > in Fortran. After the introduction of stricter checking later during > compilation, these extra nodes could cause ICEs, as seen in the PR. > > The patch also fixes cases that "happened to work" previously where > the user attaches/detaches a pointer to array using a descriptor, and > (I think!) the "_data" field has offset zero, hence the same address as > the descriptor as a whole.
Thanks for looking into this. I haven't reviewed the patch itself, but noticed one thing: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/pr109622-2.f90 > +!$acc enter data copyin(var) > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/pr109622-3.f90 > +!$acc enter data copyin(var, tgt) > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/pr109622.f90 > +!$acc enter data copyin(var, var2) You'll want to move these into 'libgomp/testsuite/libgomp.oacc-fortran/' to actually test them with '-fopenacc' instead of '-fopenmp'. ;-) Chalk up one for the idea that I once had, to have '-fopenacc', '-fopenmp', '-fopenmp-simd' enable '-Wunknown-pragmas' by default. Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
