On 28.04.23 11:31, Thomas Schwinge wrote:
On 2023-04-28T10:48:31+0200, Tobias Burnus <tob...@codesourcery.com> wrote:
I don't think that just calling "exit (EXIT_FAILURE);" is the the proper
way
The point is, when we run into such an 'exit', we've already issued an
error (in the plugin, via 'GOMP_PLUGIN_fatal'),
you meant: GOMP_PLUGIN_error.
and then (to replicate
what 'GOMP_PLUGIN_fatal'/'gomp_fatal' do) we just need to 'exit' -- after
unlocking. The latter is the reason why we can't just do this:
– I think that should be GOMP_PLUGIN_fatal in the plugin and
gomp_fatal in target.c.
..., because we'd dead-lock due to 'atexit' shutdown of devices etc.,
while still having devices etc. locked.
(Resolving all this differently/"properly" is for another day.)
→ https://gcc.gnu.org/PR109664
Otherwise, it LGTM.
Thanks. OK to push then, given the rationale above?
OK.
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
