On Thu, 20 Apr 2023, juzhe.zh...@rivai.ai wrote: > Thanks Richards (Sandiford && Biener). > I have a technique question: > In case of support variable IVs for memory address calculation, is it right I > should make output of WHILE_LEN > visible in tree-ssa-loop-ivopts.cc ? Since the address calculation is not in > the loop control handling function.
Well, it is visible, no? It's going to be not different from SVE testing the mask for all zeros. I'd leave trying to make IVOPTs eliminate other counting IVs with the WHILE_LEN result as a followup exercise - you will likely have address IVs that do not depend on the WHILE_LEN result for all of the memory accesses. Richard. > Thanks. > > > juzhe.zh...@rivai.ai > > From: Richard Sandiford > Date: 2023-04-20 17:54 > To: Richard Biener > CC: juzhe.zhong\@rivai.ai; gcc-patches; jeffreyalaw > Subject: Re: [PATCH] VECT: Add WHILE_LEN pattern for decrement IV support for > auto-vectorization > Richard Biener <rguent...@suse.de> writes: > > On Thu, 20 Apr 2023, Richard Sandiford wrote: > > > >> "juzhe.zh...@rivai.ai" <juzhe.zh...@rivai.ai> writes: > >> > OK. Thanks Richard. > >> > So let me conclude: > >> > 1. Community agree that I should support variable IV in the middle-end. > >> > 2. We can keep WHILE_LEN pattern when "not only final iteration is > >> > partial". > >> > And I should describe it more clearly in the doc. > >> > > >> > I should do these 2 things in the later update patch. > >> > >> Sounds good to me, but Richi is the maintainer. > > > > But I happily defer to you for designing VL stuff. I suppose it's > > time to make you maintainer as well ... (you are global reviewer). > > Heh, wasn't trying to bag an extra maintainership :-) I just got a > bit lost in the thread and wasn't sure whether I was contradicting > something you'd said (in which case I'd defer to that). > > Richard > > > > -- Richard Biener <rguent...@suse.de> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)
