On 4/5/23 08:21, Segher Boessenkool wrote:
Hi!
On Wed, Mar 29, 2023 at 07:48:00AM -0600, Jeff Law wrote:
So as mentioned in the PR the underlying issue here is combine changes
the form of an existing insn, but fails to force re-recognition. As a
result other parts of the compiler blow up.
[snip]
The fix is trivial, reset the INSN_CODE to force re-recognition in the
case where try_combine fails.
Thanks for the clear explanation! Okay for trunk. Also okay for all
backports (after a week or so on trunk).
Thanks. I haven't seen this on any of the release branches, so no
strong opinions on backporting at this time. It's a pretty narrow bug
(no surprise given its been latent for something like 10 years).
* combine.cc (combine_instructions): Force re-recognition when
potentially changing the underlying RTL structure of an insn.
When returning the original, might be clearer?
Yea. I'll update the ChangeLog entry.
Thanks,
Jeff
