On 3/27/23 17:17, Costas Argyris wrote:
The patch attached to this email extends the UTF-8 support of the
driver and compiler processes to the 32-bit mingw host. Initially,
only the 64-bit host got it.
About the changes in sym-mingw32.cc:
Even though the 64-bit host was building fine with the symbol being
simply declared as a char, the 32-bit host was failing to find the
symbol at link time because a leading underscore was being added
to it by the compiler. The asm keyword ensures that the symbol
always appears with that exact name, such that the linker will
always find it.
The patch also includes Jacek's flag about adding the .manifest file
as a prerequisite for the object file (this was actually done from before
but an earlier version of the patch was pushed so it was missed).
Tested building from master for both 32 and 64-bit mingw hosts using:
1) cross-compilation from a Debian machine using configure + make
2) native-compilation from a Windows machine using MSYS2
Thanks, approved and pushed to master branch.
