On Fri, 2023-03-24 at 18:45 +0100, Alejandro Colomar wrote: > Hi David, > > On 3/24/23 15:53, David Malcolm wrote: > > On Fri, 2023-03-24 at 14:39 +0100, Alejandro Colomar via Gcc- > > patches > > wrote: > > > Warn about the following: > > > > > > char s[3] = "foo"; > > > > [...] > > > > --- > > > > > > Hi, > > > > Hi Alex, thanks for the patch. > > :) > > > > > > > > > I sent v1 to the wrong list. This time I've made sure to write > > > to > > > gcc-patches@. > > > > Note that right now we're deep in bug-fixing/stabilization for GCC > > 13 > > (and trunk is still tracking that effort), so your patch might be > > more > > suitable for GCC 14. > > Sure, no problem. Do you have a "next" branch where you pick patches > for after the release, or should I resend after the release?
We don't; resending it after release is probably best. > Is > discussion of a patch reasonable now, or is it too much distracting > from your stabilization efforts? FWIW I'd prefer to postpone the discussion until after we branch for the release. > > > > > > > > > v2 adds some draft of a test, as suggested by Martin. However, I > > > don't > > > know yet how to write those, so the test is just a draft. But I > > > did > > > test the feature, by compiling GCC and compiling some small > > > program > > > with > > > it. > > > > Unfortunately the answer to the question "how do I run just one > > testcase in GCC's testsuite" is rather non-trivial; FWIW I've > > written > > up some notes on working with the GCC testsuite here: > > https://gcc-newbies-guide.readthedocs.io/en/latest/working-with-the-testsuite.html > > Hmm, I'll try following that; thanks! Is there anything obvious that > I might have missed, at first glance? The main thing is that there's a difference between compiling the test case "by hand", versus doing it through the test harness - the latter sets up the environment in a particular way, injects a particular set of flags, etc etc. Dave
