On Mon, 28 Nov 2022 at 20:44, François Dumont wrote: > > On 28/11/22 19:35, Jonathan Wakely wrote: > > > > On Mon, 28 Nov 2022 at 06:07, François Dumont via Libstdc++ > <libstd...@gcc.gnu.org> wrote: >> >> This patch is fixing those tests: >> >> 20_util/to_chars/float128_c++23.cc >> std/format/formatter/requirements.cc >> std/format/functions/format.cc >> std/format/functions/format_to_n.cc >> std/format/functions/size.cc >> std/format/functions/vformat_to.cc >> std/format/string.cc >> >> Note that symbols used in <format> for __ibm128 and __iee128 are untested. > > > We don't need to do this for those symbols, the ALT128 config is incompatible > with versioned namespace. If you're using the versioned namespace, you don't > need backwards compatibility with the old long double ABI. > > > > > Here is the simplified patch then. > > libstdc++: [_GLIBCXX_INLINE_VERSION] Add to_chars/from_chars symbols > export > > libstdc++-v3/ChangeLog > > * include/std/format [_GLIBCXX_INLINE_VERSION](to_chars): Adapt > __asm symbol > specifications. > * config/abi/pre/gnu-versioned-namespace.ver: Add > to_chars/from_chars symbols > export. > > Ok to commit ?
I still don't understand why the linker script change is needed, but I can investigate that myself later. OK for trunk, thanks.
