On Fri, Dec 23, 2022 at 7:00 PM Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > On 12/22/22 12:28, i.nix...@autistici.org wrote: > > On 2022-12-22 12:21, Jonathan Yong wrote: > > > > hello, > > > >> On 12/16/22 19:20, Eric Botcazou wrote: > >>>> The libgcc parts look reasonable to me, but I can't approve them. > >>>> Maybe Jonathan Yong can approve those parts as mingw-w64 target > >>>> maintainer, or maybe a libgcc approver can do so. > >>> > >>> OK. > >>> > >>>> The libstdc++ parts are OK for trunk. IIUC they could go in > >>>> separately, they just wouldn't be very much use without the libgcc > >>>> changes. > >>> > >>> Sure thing. > >>> > >> > >> Ping, need help to commit it? > > > > yes, it would be great if we can merge the path into gcc-13! > > > > I've tested it on gcc-12-branch and gcc-master for i686/x86_64 windows, > > with msvcrt and ucrt runtime - works as it should! > > > > Eric ^^^ > > > > > > > > best! > > Done, pushed to master branch. Thanks Eric.
I think this might have broken fortran. I'm assuming because the backtrace includes gthr.h, and I just did a git pull: In file included from /tmp/rtmingw/mingw/include/windows.h:71, from ../libgcc/gthr-default.h:606, from ../../../libgfortran/../libgcc/gthr.h:148, from ../../../libgfortran/io/io.h:33, from ../../../libgfortran/runtime/error.c:27: ../../../libgfortran/io/io.h:298:24: error: expected identifier before numeric constant 298 | { CC_LIST, CC_FORTRAN, CC_NONE, | ^~~~~~~