Hi! On 2022-12-07T09:50:40+0100, Arsen Arsenović via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > arthur.co...@embecosm.com writes: > >> This is a wrapper for make_unique. We can likely get rid of this, as there >> are other implementations available, or simply keep using the unique_ptr >> constructor. >> --- >> gcc/rust/util/rust-make-unique.h | 35 ++++++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 gcc/rust/util/rust-make-unique.h >> >> diff --git a/gcc/rust/util/rust-make-unique.h >> b/gcc/rust/util/rust-make-unique.h >> new file mode 100644 >> index 00000000000..7b79e625ff1 >> --- /dev/null >> +++ b/gcc/rust/util/rust-make-unique.h >> @@ -0,0 +1,35 @@ >> +// Copyright (C) 2020-2022 Free Software Foundation, Inc. >> + >> +// This file is part of GCC. >> + >> +// GCC is free software; you can redistribute it and/or modify it under >> +// the terms of the GNU General Public License as published by the Free >> +// Software Foundation; either version 3, or (at your option) any later >> +// version. >> + >> +// GCC is distributed in the hope that it will be useful, but WITHOUT ANY >> +// WARRANTY; without even the implied warranty of MERCHANTABILITY or >> +// FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >> +// for more details. >> + >> +// You should have received a copy of the GNU General Public License >> +// along with GCC; see the file COPYING3. If not see >> +// <http://www.gnu.org/licenses/>. >> + >> +#ifndef RUST_MAKE_UNIQUE_H >> +#define RUST_MAKE_UNIQUE_H >> + >> +#include "rust-system.h" >> + >> +namespace Rust { >> + >> +template <typename T, typename... Ts> >> +std::unique_ptr<T> >> +make_unique (Ts &&...params) >> +{ >> + return std::unique_ptr<T> (new T (std::forward<Ts> (params)...)); >> +} >> + >> +} // namespace Rust >> + >> +#endif // RUST_MAKE_UNIQUE_H > > I think this was added recently, see commit > 00d7c8ff16e6838273cea808ffbe22e98104f9d5 and gcc/make-unique.h.
I too had seen that, but decided to wait for until after the GCC/Rust merge, to not add more complexity to that one. It's OK, in my opinion, to add 'gcc/rust/util/rust-make-unique.h' now, and then later re-factor/get rid of that, to use 'gcc/make-unique.h' instead. Anyway, thanks for pointing that out, of course! :-) Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
