on 2022/12/7 13:24, HAO CHEN GUI wrote: > Hi Kewen, > Thanks so much for your review comments. I will fix them. > > 在 2022/12/7 11:06, Kewen.Lin 写道: >> Does this issue which relies on the fix for generic part make bootstrapping >> fail? >> If no, how many failures it can cause? I'm thinking if we can commit this >> firstly, >> then in the commit log of the fix for generic part you can mention it can >> fix the >> ICE exposed by this test case. > > Yes, the bootstrapping fails if we enable cbranchcc4 without the generic > patch. > Actually, the testcase comes from the ICE found in bootstrapping.
Ah, thanks for confirming, so the fix for the generic part should come first. I just noticed Richi has approved it, you can mention this test case gcc.target/powerpc/cbranchcc4-1.c in the commit log for a record when committing it. Thanks! BR, Kewen
