On Tue, Apr 10, 2012 at 11:46 AM, Manuel López-Ibáñez <lopeziba...@gmail.com> wrote: > On 10 April 2012 00:28, Jason Merrill <ja...@redhat.com> wrote: >> On 04/09/2012 04:01 PM, Manuel López-Ibáńez wrote: >>> >>> * It uses the default cutoff as max_width, whatever it is (as >>> controlled by -fmessage-length). >>> * It uses the pretty-printer. The text cannot (should not) wrap >>> because we still print only max_width chars at most. >> >> >> Hmm, I think if pp_line_cutoff is 0 and we're on a terminal, we still want >> to use COLUMNS to limit how much of the source we print. > > Like this?
There is a novelty in this new version that I don't think we discussed before: automatic expansion of tabs to 8 hard space characters. That number should not be hardcoded as there is no reason to believe a tab character always expands to 8 space characters. You should check the environment first; if not present the default expansion number should be a symbolic constant as opposed to a magic number sprinkled all over the places. I would also encourage you to introduce more abstraction to reduce the size of diagnostic_show_locus.
