On Fri, 25 Nov 2022, Zopolis0 via Gcc-patches wrote: > Firstly, to get feedback and reviews on the 56 already existing > patches, even though most are just re-adding code or making idiomatic > changes, so that when the final issue is solved everything has already > been approved (hopefully) and the merge is good to go.
I think a lot more explanation is needed to get much useful feedback. * Each patch should have its own explanation of what it is doing and why, in the message body (not in an attachment). Just the commit summary line and ChangeLog entries aren't enough, we need the actual substantive commit message explaining the patch. * An overall explanation is needed of what the patch series is doing and why. Why is it now considered useful to add this front end back? Which version is the basis of the one being added back - the version removed from GCC (that used ECJ for converting Java source to Java byte-code), or some other version? How has the series been validated? Would you propose to maintain the front end and libraries in future? Would you re-open any bugs against the front end or libraries that were closed (as WONTFIX or otherwise) as a result of it being removed from the tree (maybe when it was removed, maybe later when the last release series with the front end ceased to be supported)? And so on. -- Joseph S. Myers jos...@codesourcery.com
