Le 21/11/2022 à 21:34, Bernhard Reutner-Fischer a écrit :
On Mon, 21 Nov 2022 12:08:20 +0100
Mikael Morin <morin-mik...@orange.fr> wrote:

        * gfortran.h (struct ext_attr_t): Remove middle_end_name.
        * trans-decl.cc (add_attributes_to_decl): Move building
        tree_list to ...
        * decl.cc (gfc_match_gcc_attributes): ... here. Add the attribute to
        the tree_list for the middle end.
I prefer to not do any middle-end stuff at parsing time, so I would
rather not do this change.
Not OK.

Ok, that means we should filter-out those bits that we don't want to
write to the module (right?). We've plenty of bits left, more than Dave
Love would want to have added, i hope, so that should not be much of a
concern.

I didn't think of modules. Yes, that means we have to store (in memory) the attribute we have parsed, and we can filter-out the attributes at the time the attributes are written to the module. I don't think it is strictly necessary (for flatten, at least) though.

What that table really wants to say is whether or not this attribute
should be passed to the ME. Would it be acceptable to remove these
duplicate strings and just have a bool/char/int that is true if it
should be lowered (in trans-decl, as before)? But now i admit it's just
bikeshedding and we can as well leave it alone for now.. It was just a
though.

Yes, that would be acceptable.

Reply via email to