Richard Biener <richard.guent...@gmail.com> writes: [snip]
> It feels like most of the above would usually be handled via lang specific > specs rather than open-coded in the driver? Is there a specific reason you > opted for explicit handling here? The last time submitting the patches I perhaps went overboard using lang-specs - and so tried to adopt the style from C++/fortran this time around. I'm happy to utilize lang-specs to reduce the driver code though. > Otherwise the patch looks generally OK, the string builds using strcat & > friends > looks like it neither takes advantage of how obstacks can be used there nor > that we're now C++ and could use std::string - but that's a matter of taste > and > no objection. ok thanks! regards, Gaius
