>>>>> "Andrew" == apinski--- via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
Andrew> From: Andrew Pinski <apin...@marvell.com> Andrew> This patch uses the toplevel configure parts for GMP/MPFR for Andrew> gdb. The only thing is that gdb now requires MPFR for building. Andrew> Before it was a recommended but not required library. Andrew> Also this allows building of GMP and MPFR with the toplevel Andrew> directory just like how it is done for GCC. Andrew> We now error out in the toplevel configure of the version Andrew> of GMP and MPFR that is wrong. Thank you for doing this. It's been on my to-do list to investigate this for quite a while, but I never got to it... :( One larger question I have is whether we should land this now, or wait until after GDB 13 branches. That is coming soon and maybe it's not good to add a new dependency just before the release. My inclination would be to defer it, I suppose out of conservatism, but I'd appreciate hearing from others. I think gdb/README and gdb/doc/gdb.texinfo need some minor changes, because the GMP-related configure options are being renamed. The commit message should mention "PR build/28500" somewhere so that the commit is logged to bugzilla. Also in gdb we've been using a "Bug:" trailer in the commit message that has the full URL of the bug. IIUC this does fix that PR. Tom
