Martin Liška <mli...@suse.cz> writes: > 1) I would prefer using ' instead of ": > > $ flake8 ./gcc/m2/tools-src/tidydates.py > ... > ./gcc/m2/tools-src/tidydates.py:124:30: Q000 Double quotes found but single > quotes preferred > ./gcc/m2/tools-src/tidydates.py:127:27: Q000 Double quotes found but single > quotes preferred > ./gcc/m2/tools-src/tidydates.py:132:27: Q000 Double quotes found but single > quotes preferred > ./gcc/m2/tools-src/tidydates.py:133:33: Q000 Double quotes found but single > quotes preferred > ./gcc/m2/tools-src/tidydates.py:138:26: Q000 Double quotes found but single > quotes preferred > ./gcc/m2/tools-src/tidydates.py:143:28: Q000 Double quotes found but > single quotes preferred
ah yes will switch the quotes character. > 2) Python-names would be nicer: > > def writeTemplate(fo, magic, start, end, dates, contribution, summary, > lic): > > def write_template(...) agreed, will change > 3) def hasExt(name, ext) - please use Path from pathlib > > 4) while (str.find(line, "(*") != -1): > > '(*' in line > ? Similarly elsewhere. > > 5) str.find(line, ...) > > Use rather directly: line.find(...) > > 6) please use flake8: > https://gcc.gnu.org/codingconventions.html#python sure will do all above - I used flake8 but maybe the plugins weren't enabled. I'll try flake8 on tumbleweed. > Thanks, > Martin > > P.S. I'm going to merge Sphinx branch this Wednesday, so then we should port > your > conversion scripts to emit .rst instead of .texi. should be good - I'll complete the rst output in the scripts, regards, Gaius
