On Fri, 2022-11-04 at 10:27 -0400, Jason Merrill wrote: > On 11/3/22 19:06, David Malcolm wrote: > > On Thu, 2022-11-03 at 15:59 -0400, Jason Merrill via Gcc-patches > > wrote:
[...snip...] > > > > > > Do you have test coverage for this from the DejaGnu side? If not, > > you > > could add selftest coverage for this; see input.cc's > > test_reading_source_line for something similar. > > There is test coverage for the output of the the contract violation > handler, which involves printing the result of this function. Thanks. Is this test posted somwehere? I was looking in: https://gcc.gnu.org/pipermail/gcc-patches/2022-November/604974.html but I'm not seeing it. Sorry if I'm missing something here. Ideally we should have coverage for the three cases of: (a) bails out and returns NULL (b) single-line case (c) multi-line case > index a28abfac5ac..04d0809bfdf 100644 > --- a/gcc/input.cc > +++ b/gcc/input.cc > @@ -949,6 +949,97 @@ location_get_source_line (const char *file_path, int > line) > return char_span (buffer, len); > } Strings in input.cc are not always NUL-terminated, so... > > +/* Return a copy of the source text between two locations. The caller is > + responsible for freeing the return value. */ ...please note in the comment that if non-NULL, the copy is NUL- terminated (I checked both exit paths that can return non-NULL, and they do NUL-terminate their buffers). OK with that nit fixed. Thanks Dave
