%{On Wed, 2022-10-26 at 10:18 +0200, arthur.co...@embecosm.com wrote:
> From: Philip Herron <philip.her...@embecosm.com>
>
> Extern crates statements to tell the front-end to look for another
> library.
> The mechanism here is heavily inspired from gccgo, so when we compile
> a
> library for example we invoke:
>
[...snip...]
> + rust_error_at (Location (),
> + "expected metadata-output path to have base file
> name of: "
> + "%<%s%> got %<%s%>",
> + expected_file_name.c_str (), path_base_name);
I can't comment on the patch in depth, but does rust_error_at call into
GCC's regular diagnostics?
If so, "%qs" is a more idiomatic way to express printing a string
argument in quotes (and bold), rather than "%<%s%>", though IIRC they
do the same thing (unless I'm missing something?).
This shows up in a few places in this patch, and might affect other
patches in the kit - though it's a minor nitpick, of course.
Dave
