On Thu, Oct 20, 2022 at 5:15 AM Segher Boessenkool <seg...@kernel.crashing.org> wrote: > > On Wed, Oct 19, 2022 at 10:14:28AM -0700, Andrew Pinski wrote: > > Do the testcases really need to be changed rather than adding new testcases? > > Usually it is better if the testcases not change unless really needed > > to be. That is do these testcases pass without being changed? If not > > this seems not backwards compatible change and is not something which > > we should do. Otherwise you should just add new testcases instead. > > Yes, that is another reason why adding parameters to random builtins is > not a good idea :-) s/random/only vaguely related/, if you want. > > This also makes all existing code using these builtins invalid. If you > need such testcase changes, that is a red flag. The default behavior is the same as before(default data prefetch, we'll unchange those testcases.) > > > Segher
-- BR, Hongtao
