Hi! On 2022-09-12T14:02:16+0200, Tobias Burnus <tob...@codesourcery.com> wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c > @@ -0,0 +1,15 @@ > +/* { dg-do link { target { offload_target_nvptx } } } */ > +/* { dg-additional-options "-foffload-options=nvptx-none=-march=sm_30 > -foffload=-mptx=_" } */
Pushed to master branch commit b61796663ba1fe8fb83203829398f3f89ec212b7 "Fix nvptx-specific '-foffload-options' syntax in 'libgomp.c/reverse-offload-sm30.c'", see attached. Cherry-picked pushed to devel/omp/gcc-12 branch in commit f36ce95ad928578aa6739f61480e6c8fbaf2248e "Fix nvptx-specific '-foffload-options' syntax in 'libgomp.c/reverse-offload-sm30.c'", see attached. Grüße Thomas > + > +#pragma omp requires reverse_offload > + > +int > +main () > +{ > + #pragma omp target > + { > + } > + return 0; > +} > + > +/* { dg-warning "'omp requires reverse_offload' requires at least 'sm_35' > for '-march=' - disabling offload-code generation for this device type" "" { > target *-*-* } 0 } */ ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
>From b61796663ba1fe8fb83203829398f3f89ec212b7 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge <tho...@codesourcery.com> Date: Fri, 23 Sep 2022 11:29:50 +0200 Subject: [PATCH] Fix nvptx-specific '-foffload-options' syntax in 'libgomp.c/reverse-offload-sm30.c' That is, '-mptx=_' is only valid in '-foffload-options=nvptx-none', too. Fix test case added in recent commit r13-2625-g6b43f556f392a7165582aca36a19fe7389d995b2 "nvptx/mkoffload.cc: Warn instead of error when reverse offload is not possible". libgomp/ * testsuite/libgomp.c/reverse-offload-sm30.c: Fix nvptx-specific '-foffload-options' syntax. --- libgomp/testsuite/libgomp.c/reverse-offload-sm30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c b/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c index fbfeae1fd41..7f10fd4ded9 100644 --- a/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c +++ b/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c @@ -1,5 +1,5 @@ /* { dg-do link { target { offload_target_nvptx } } } */ -/* { dg-additional-options "-foffload-options=nvptx-none=-march=sm_30 -foffload=-mptx=_" } */ +/* { dg-additional-options "-foffload-options=nvptx-none=-march=sm_30 -foffload-options=nvptx-none=-mptx=_" } */ #pragma omp requires reverse_offload -- 2.35.1
>From f36ce95ad928578aa6739f61480e6c8fbaf2248e Mon Sep 17 00:00:00 2001 From: Thomas Schwinge <tho...@codesourcery.com> Date: Fri, 23 Sep 2022 11:29:50 +0200 Subject: [PATCH] Fix nvptx-specific '-foffload-options' syntax in 'libgomp.c/reverse-offload-sm30.c' That is, '-mptx=_' is only valid in '-foffload-options=nvptx-none', too. Fix test case added in recent commit r13-2625-g6b43f556f392a7165582aca36a19fe7389d995b2 "nvptx/mkoffload.cc: Warn instead of error when reverse offload is not possible". libgomp/ * testsuite/libgomp.c/reverse-offload-sm30.c: Fix nvptx-specific '-foffload-options' syntax. (cherry picked from commit b61796663ba1fe8fb83203829398f3f89ec212b7) --- libgomp/ChangeLog.omp | 8 ++++++++ libgomp/testsuite/libgomp.c/reverse-offload-sm30.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp index cb3541be378..048314eb1be 100644 --- a/libgomp/ChangeLog.omp +++ b/libgomp/ChangeLog.omp @@ -1,3 +1,11 @@ +2022-10-17 Thomas Schwinge <tho...@codesourcery.com> + + Backported from master: + 2022-10-17 Thomas Schwinge <tho...@codesourcery.com> + + * testsuite/libgomp.c/reverse-offload-sm30.c: Fix nvptx-specific + '-foffload-options' syntax. + 2022-10-14 Julian Brown <jul...@codesourcery.com> * testsuite/libgomp.oacc-fortran/declare-1.f90: Adjust scan output. diff --git a/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c b/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c index fbfeae1fd41..7f10fd4ded9 100644 --- a/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c +++ b/libgomp/testsuite/libgomp.c/reverse-offload-sm30.c @@ -1,5 +1,5 @@ /* { dg-do link { target { offload_target_nvptx } } } */ -/* { dg-additional-options "-foffload-options=nvptx-none=-march=sm_30 -foffload=-mptx=_" } */ +/* { dg-additional-options "-foffload-options=nvptx-none=-march=sm_30 -foffload-options=nvptx-none=-mptx=_" } */ #pragma omp requires reverse_offload -- 2.35.1