On Mon, Apr 02, 2012 at 06:56:25PM +0400, Andrey Belevantsev wrote: > After Richi's RTL generation related cleanups went it, the extra > cleanup_cfg call was added so we are no longer lucky to have the > proper fallthru edge in this case. The PR trail has the patch to > purge_dead_edges making it consider this situation, but I still > prefer the below patch that fixes only the invalid asm case. The > reason is that I think it unlikely that after initial RTL expansion > (of which the instantiate virtual regs pass seems to be the part) we > will get the problematic situation. However, I'm happy to test the > PR trail patch, too.
I don't like blindly changing edge into FALLTHRU, generally the edge could be abnormal, or EH, etc. and making that fallthru is not a good idea. I'd prefer if wherever the fallthru edge is removed the other normal edge(s) are adjusted. Jakub