Hi Segher,
on 2022/9/30 04:31, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Aug 24, 2022 at 04:17:07PM +0800, Kewen.Lin wrote:
>> --- a/gcc/config/rs6000/rs6000.cc
>> +++ b/gcc/config/rs6000/rs6000.cc
>> @@ -14771,18 +14771,9 @@ rs6000_print_patchable_function_entry (FILE *file,
>> unsigned HOST_WIDE_INT patch_area_size,
>> bool record_p)
>> {
>> - unsigned int flags = SECTION_WRITE | SECTION_RELRO;
>> - /* When .opd section is emitted, the function symbol
>> - default_print_patchable_function_entry_1 is emitted into the .opd
>> section
>> - while the patchable area is emitted into the function section.
>> - Don't use SECTION_LINK_ORDER in that case. */
>> - if (!(TARGET_64BIT && DEFAULT_ABI != ABI_ELFv2)
>> - && HAVE_GAS_SECTION_LINK_ORDER)
>> - flags |= SECTION_LINK_ORDER;
>> - default_print_patchable_function_entry_1 (file, patch_area_size, record_p,
>> - flags);
>> + default_print_patchable_function_entry (file, patch_area_size, record_p);
>> }
>
> Please don't define TARGET_ASM_PRINT_PATCHABLE_FUNCTION_ENTRY at all,
> instead, and remove this whole function?
This hook is still needed for "ELFv2 support rework" which
was just committed in r13-2984. There is also a note
explaining this in the original mail:
"btw, rs6000_print_patchable_function_entry can be dropped
but there is another rs6000 patch which needs this rs6000
specific hook rs6000_print_patchable_function_entry, not
sure which one gets landed first, so just leave it here."
>
> The rs6000 changes are okay like that, thanks!
Thanks!
BR,
Kewen
