Re: [PATCH] Restore XCOFF for DWARF on AIX.

[Richard Biener via Gcc-patches]

> Am 07.09.2022 um 16:37 schrieb Martin Liška <mli...@suse.cz>:
> 
> On 9/7/22 15:43, David Edelsohn wrote:
>> On Wed, Sep 7, 2022 at 7:45 AM Martin Liška <mli...@suse.cz 
>> <mailto:mli...@suse.cz>> wrote:
>> 
>>    Hi.
>> 
>>    The patch restores DWARF support for AIX target where XCOFF file 
>> container is used.
>>    Verified before and after the patch, gcc119 machine (AIX) could not build 
>> any run-time library,
>>    now it can.
>> 
>>    Ready to be installed?
>>    Thanks,
>>    Martin
>> 
>>            PR bootstrap/106855
>> 
>>    gcc/ChangeLog:
>> 
>>            * collect2.cc (scan_prog_file): Restore if XCOFF_DEBUGGING_INFO.
>>            * config/rs6000/rs6000.cc (rs6000_option_override_internal):
>>              Restore usage of XCOFF_DEBUGGING_INFO.
>>            * config/rs6000/xcoff.h (XCOFF_DEBUGGING_INFO): Restore.
>>            * dwarf2asm.cc (XCOFF_DEBUGGING_INFO): Restore support for
>>              XCOFF_DEBUGGING_INFO.
>>            (dw2_asm_output_nstring): Likewise.
>>            (USE_LINKONCE_INDIRECT): Likewise.
>>            * dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise.
>>            (HAVE_XCOFF_DWARF_EXTRAS): Likewise.
>>            (output_fde): Likewise.
>>            (output_call_frame_info): Likewise.
>>            (have_macinfo): Likewise.
>>            (add_AT_loc_list): Likewise.
>>            (add_AT_view_list): Likewise.
>>            (output_compilation_unit_header): Likewise.
>>            (output_pubnames): Likewise.
>>            (output_aranges): Likewise.
>>            (output_line_info): Likewise.
>>            (output_macinfo): Likewise.
>>            (dwarf2out_finish): Likewise.
>>            (dwarf2out_early_finish): Likewise.
>> 
>> 
>> Hi, Martin
>> 
>> Thanks for the quick patch to fix this.  This restores bootstrap, but does 
>> not completely restore functionality.  This patch did not restore the 
>> gcc/configure test for AIX assembler XCOFF feature support that defines 
>> HAVE_XCOFF_DWARF_EXTRAS.  That part of the removal patch also needs to be 
>> reverted.
> 
> Ohh! Sorry about that, should be restored by the following patch.
> 
> Ready for master?

Ok.

Richard 


> Thanks,
> Martin
> 
>> 
>> Thanks, David
>>  
> <0001-Restore-detection-of-HAVE_XCOFF_DWARF_EXTRAS.patch>