On Wed, Aug 31, 2022 at 01:53:48PM -0500, Peter Bergner wrote: > ...and of course, now I can't recreate that issue at all and the > ptr_vector_*_type use work fine now. Strange! ...so ok, changed. > Maybe the behavior changed since my PR106017 fix went in???
That is my best guess as well. But, how did that help this test? > Question for my own education, when would you use VIEW_CONVERT_EXPR over > NOP_EXPR? VIEW_CONVERT_EXPR is essentially a bit_cast. Only use it when you need that, it is sub-optimal if you don't. > FYI, here is the current code patch with all of the suggested changes > incorporated: > --- a/gcc/config/rs6000/rs6000-builtin.cc > +++ b/gcc/config/rs6000/rs6000-builtin.cc > @@ -1085,7 +1085,11 @@ rs6000_gimple_fold_mma_builtin (gimple_stmt_iterator > *gsi, > unsigned nvec = (fncode == RS6000_BIF_DISASSEMBLE_ACC) ? 4 : 2; > tree dst_ptr = gimple_call_arg (stmt, 0); > tree src_ptr = gimple_call_arg (stmt, 1); > - tree src_type = TREE_TYPE (src_ptr); > + tree src_type = (fncode == RS6000_BIF_DISASSEMBLE_ACC) > + ? ptr_vector_quad_type_node : ptr_vector_pair_type_node; If you split a?b:c over multiple lines, please make it three lines. Segher
