On 8/31/22 4:33 AM, Kewen.Lin wrote: > @@ -1,7 +1,8 @@ > /* { dg-do compile { target { powerpc*-*-* } } } */ > /* { dg-skip-if "" { powerpc*-*-aix* } } */ > -/* { dg-options "-O2 -mpowerpc64" } */ > /* { dg-require-effective-target ilp32 } */ > +/* { dg-options "-O2 -mpowerpc64" } */ > +/* { dg-require-effective-target has_arch_ppc64 } */
With many of our recent patches moving the dg-options before any dg-requires-effectice-target so it affects the results of the dg-requires-effectice-target test, this looks like it's backwards from that process. I understand why, so I think an explicit comment here in the test case explaining why it's after in this case. Just so in a few years when we come back to this test case, we won't accidentally undo this change. The other option would be to introduce -mdejagnu-32 and -mdejagnu-64 options that operate like our -mdejagnu-cpu= options and override any -m32/-m64 option given on the command line (eg, RUNTESTFLAGS=...). To be honest, I'm not sure how I feel about this suggestion! :-) Maybe we'd only use it on the test cases like this one that we know are sensitive to be overridden??? Peter