On 8/25/22 17:49, Marek Polacek wrote:
On Thu, Aug 25, 2022 at 09:25:43AM -0400, Jason Merrill wrote:
On 8/24/22 17:30, Marek Polacek wrote:
On Tue, Aug 23, 2022 at 05:27:00PM -0400, Jason Merrill wrote:
On 8/23/22 09:39, Marek Polacek wrote:
+ tree arg = CALL_EXPR_ARG (fn, 0);
+ extract_op (arg);
+ if (TREE_CODE (arg) == ADDR_EXPR)
+ arg = TREE_OPERAND (arg, 0);
+ tree type = TREE_TYPE (lhs);
+ lhs = maybe_undo_parenthesized_ref (lhs);
+ STRIP_ANY_LOCATION_WRAPPER (lhs);
+ const bool print_var_p = (DECL_P (lhs)
+ || REFERENCE_REF_P (lhs)
+ || TREE_CODE (lhs) == COMPONENT_REF);
Why include REFERENCE_REF_P and COMPONENT_REF? Reference refs should be
stripped before this test, member refs aren't variables.
I'm checking REFERENCE_REF_P and COMPONENT_REF to say "moving a variable"
in #1 and #3. The REFERENCE_REF_P check means that we also say "variable"
for #2. Sure, "A variable is introduced by the declaration of a reference
other than a non-static data member", but I'm not sure if users care about
that here?
If I strip REFERENCE_REFs before the check then the result will be the
same.
That's what I was suggesting, yes: Strip the REFERENCE_REF so DECL_P can see
the decl.
Ok, I've added the REFERENCE_REF stripping. But I've still left the
COMPONENT_REF in. Perhaps we could say "moving a member" to itself for
COMPONENT_REFs. Or just say "moving 'x' of type 'int' to itself" and
avoid all of this. :)
Sure, that would be simpler. In any case, we shouldn't call member
references variables.
Jason
