On Thu, 2022-08-25 at 16:29 +0800, Lulu Cheng wrote:
> 
> 在 2022/8/24 下午10:03, Xi Ruoyao 写道:
>  
> > SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS
> > invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF.
> > 
> > r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))" before invoking
> > "SYMBOL_REF_TLS_MODEL (x)", indicating that it's now possible that
> > "x"
> > is not a SYMBOL_REF.  So we need to check if "x" is SYMBOL_REF
> > first.
> > 
> > This fixes a test failure happening with r13-2173:
> > 
> >     pr106096.C:26:1: internal compiler error: RTL flag check:
> >     SYMBOL_REF_FLAGS used with unexpected rtx code 'const' in
> >     loongarch_classify_symbol
> 
> I think there is no problem with the code modification, but I have not
> detected this ICE.

If ENABLE_RTL_CHECKING is disabled (for example, use --enable-
checking=release, which is also the default for release tarballs), the
check will be skipped.

-- 
Xi Ruoyao <xry...@xry111.site>
School of Aerospace Science and Technology, Xidian University

Reply via email to