On Tue, 23 Aug 2022 at 02:38, Patrick Palka via Libstdc++ <libstd...@gcc.gnu.org> wrote: > > Tested on 86_64-pc-linux-gnu, does this look OK for trunk?
As discussed privately, please remove the #include <cstdint> (which is not needed, and adds declarations to the global namespace that we don't need). OK with that change, thanks. N.B. re the TODOs, we already have a constexpr abs in <numeric> but it's probably not worth including that just for one function, that you've already managed without.
