Hi Peter, Segher, Thanks for going thru the patch! I will make the proposed changes to the Changelog.
Regards, Surya On 23/08/22 6:58 pm, Segher Boessenkool wrote: > Hi! > > On Tue, Aug 23, 2022 at 07:55:22AM -0500, Peter Bergner wrote: >> It looks good to me, but I cannot approve it. > > Same here (both statements). > >> That said, you're missing >> a ChangeLog entry for your new helper function. The ChangeLog mentions >> what changed, not why it changed. > > And that is correct! Changelogs should not say that, that isn't their > purpose (in GCC), not what they are used for. Explanations like that go > in the email and/or the commit message. > > The main remaining usefulness of changelogs is to spot unintended > commmits. > >> Maybe something like the following? >> >> gcc/ >> PR rtl-optimization/105586 >> * sched-rgn.cc (save_state_for_fallthru_edge): New function. >> (schedule_region): Use it for all blocks. > > That looks perfect, it doesn't say "why" either :-) > > > Segher
